rekahsoft/avr-lcd-lib
1
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Replaced unnecessary delays with BF check in init

Browse Source 
In the function initLCD, since the loop_until_LCD_BF_clear is working,
there is no need for manual delays at a point through the software
initialization. This fix is a remnant of commit
435c8eb07b, where the busy flag check was
fixed.

Signed-off-by: Collin J. Doering <collin.doering@rekahsoft.ca>
This commit is contained in:
Collin J. Doering 2015-10-15 02:07:19 -04:00
parent bc48704477
commit 1ba8dd6b86
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lcdLib.c
View File

@ -396,20 +396,16 @@ void initLCD (void) {
/* BF now can be checked */
// Set functions of LCD
writeLCDInstr_(INSTR_DISPLAY); // Display off
_delay_us(LCD_GENERIC_INSTR_DELAY);
writeLCDInstr(INSTR_DISPLAY); // Display off
// Clear display
writeLCDInstr_(CMD_CLEAR_DISPLAY);
_delay_us(LCD_CLEAR_DISPLAY_DELAY);
writeLCDInstr(CMD_CLEAR_DISPLAY);
// Increment mode, no shift
writeLCDInstr_(INSTR_ENTRY_SET | (1 << INSTR_ENTRY_SET_ID));
_delay_us(LCD_GENERIC_INSTR_DELAY);
writeLCDInstr(INSTR_ENTRY_SET | (1 << INSTR_ENTRY_SET_ID));
// Display on, cursor on, blink off
writeLCDInstr_(INSTR_DISPLAY | (1 << INSTR_DISPLAY_D) | (1 << INSTR_DISPLAY_C));
_delay_us(LCD_GENERIC_INSTR_DELAY);
writeLCDInstr(INSTR_DISPLAY | (1 << INSTR_DISPLAY_D) | (1 << INSTR_DISPLAY_C));
flashLED(5); // DEBUG
}