rekahsoft/qmk-firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Expand count checks in keymap introspection (#24464)

Browse Source 
* Add check Tap Dance count check to keymap introspection

* Add checks for combos and key overrides to introspection
This commit is contained in:
Drashna Jaelre 2024-10-10 12:54:53 -07:00 committed by GitHub
parent fb598e7e61
commit 49a1a12a32
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
quantum/keymap_introspection.c
View File

@ -102,6 +102,8 @@ __attribute__((weak)) uint16_t combo_count(void) {
return combo_count_raw(); return combo_count_raw();
} }
_Static_assert(ARRAY_SIZE(key_combos) <= (QK_KB), "Number of combos is abnormally high. Are you using SAFE_RANGE in an enum for combos?");
combo_t* combo_get_raw(uint16_t combo_idx) { combo_t* combo_get_raw(uint16_t combo_idx) {
if (combo_idx >= combo_count_raw()) { if (combo_idx >= combo_count_raw()) {
return NULL; return NULL;
@ -127,6 +129,8 @@ __attribute__((weak)) uint16_t tap_dance_count(void) {
return tap_dance_count_raw(); return tap_dance_count_raw();
} }
_Static_assert(ARRAY_SIZE(tap_dance_actions) <= (QK_TAP_DANCE_MAX - QK_TAP_DANCE), "Number of tap dance actions exceeds maximum. Are you using SAFE_RANGE in tap dance enum?");
tap_dance_action_t* tap_dance_get_raw(uint16_t tap_dance_idx) { tap_dance_action_t* tap_dance_get_raw(uint16_t tap_dance_idx) {
if (tap_dance_idx >= tap_dance_count_raw()) { if (tap_dance_idx >= tap_dance_count_raw()) {
return NULL; return NULL;
@ -153,6 +157,8 @@ __attribute__((weak)) uint16_t key_override_count(void) {
return key_override_count_raw(); return key_override_count_raw();
} }
_Static_assert(ARRAY_SIZE(key_overrides) <= (QK_KB), "Number of key overrides is abnormally high. Are you using SAFE_RANGE in an enum for key overrides?");
const key_override_t* key_override_get_raw(uint16_t key_override_idx) { const key_override_t* key_override_get_raw(uint16_t key_override_idx) {
if (key_override_idx >= key_override_count_raw()) { if (key_override_idx >= key_override_count_raw()) {
return NULL; return NULL;